Messages in this thread Patch in this message | | | Date | Fri, 17 Jun 2005 11:07:20 -0700 | From | Nick Wilson <> | Subject | [PATCH] NFS: fix client oops when debugging is on |
| |
nfs_readpage_release() causes an oops while accessing a file with NFS debugging turned on (echo 32767 > /proc/sys/sunrpc/nfs_debug) and a kernel built with CONFIG_DEBUG_SLAB.
This patch moves the debugging statement above nfs_release_request() to avoid accessing freed memory.
Signed-off-by: Nick Wilson <njw@osdl.org> ---
fs/nfs/read.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.12-rc6-dev.orig/fs/nfs/read.c 2005-06-16 20:34:30.000000000 -0700 +++ linux-2.6.12-rc6-dev/fs/nfs/read.c 2005-06-16 21:42:40.000000000 -0700 @@ -183,15 +183,15 @@ static void nfs_readpage_release(struct { unlock_page(req->wb_page); - nfs_clear_request(req); - nfs_release_request(req); - nfs_unlock_request(req); - dprintk("NFS: read done (%s/%Ld %d@%Ld)\n", req->wb_context->dentry->d_inode->i_sb->s_id, (long long)NFS_FILEID(req->wb_context->dentry->d_inode), req->wb_bytes, (long long)req_offset(req)); + + nfs_clear_request(req); + nfs_release_request(req); + nfs_unlock_request(req); } /* _ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |