lkml.org 
[lkml]   [2005]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [resend][PATCH] avoid signed vs unsigned comparison in efi_range_is_wc()
Jesper Juhl <juhl-lkml@dif.dk> wrote:
>
> I send in the patch below a while back but never recieved any response.
> Now I'm resending it in the hope that it might be added to -mm.

There are surely many warnings in the tree, hence I'm not really interested
in patches which only fix `gcc -W' warnings.

How many are there?

> It looks to me like a significantly large 'len' passed in could cause the
> loop to never end. Isn't it safer to make 'i' an unsigned long as well?

Nope. All operations which mix signed and unsigned types promote the
signed type to unsigned.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-16 22:50    [W:0.083 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site