lkml.org 
[lkml]   [2005]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.12-rc6] add vr41xx gpio support
Hi Andrew,

On Mon, 13 Jun 2005 15:19:40 -0700
Andrew Morton <akpm@osdl.org> wrote:

> Yoichi Yuasa <yuasa@hh.iij4u.or.jp> wrote:
> >
> > This patch had added vr41xx gpio support.
>
>
> > --- git5-orig/drivers/char/Kconfig Tue Jun 7 00:22:29 2005
> > +++ git5/drivers/char/Kconfig Sun Jun 12 02:37:20 2005
> > @@ -929,6 +929,10 @@
> >
> > If compiled as a module, it will be called scx200_gpio.
> >
> > +config GPIO_VR41XX
> > + tristate "NEC VR4100 series General-purpose I/O Unit support"
> > + depends CPU_VR41XX
> > +
>
> Does that even work? We normally use "depends on". I'll change it.

Oh, thanks.

> > +EXPORT_SYMBOL_GPL(vr41xx_set_irq_trigger);
> > +EXPORT_SYMBOL_GPL(vr41xx_set_irq_level);
> > +EXPORT_SYMBOL_GPL(vr41xx_gpio_get_pin);
> > +EXPORT_SYMBOL_GPL(vr41xx_gpio_set_pin);
> > +EXPORT_SYMBOL_GPL(vr41xx_gpio_set_direction);
> > +EXPORT_SYMBOL_GPL(vr41xx_gpio_pullupdown);
>
> Why are these symbols exported?

I'm going to send patches that use this symbol.

Yoichi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-06-14 15:06    [W:0.053 / U:0.784 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site