Messages in this thread | | | Date | Mon, 13 Jun 2005 10:10:26 +0200 | From | Willy Tarreau <> | Subject | Re: [PATCH] fix small DoS on connect() (was Re: BUG: Unusual TCP Connect() results.) |
| |
On Mon, Jun 13, 2005 at 05:45:21PM +1000, Herbert Xu wrote: > On Mon, Jun 13, 2005 at 08:17:48AM +0200, Willy Tarreau wrote: > > > > What's the problem with the sysctl ? If you prefer, I can change the patch > > to keep the feature enabled by default so that only people aware of the > > problem have to fix it by hand. But I found it better the other way : people > > who need the feature enable it by hand. > > Well that's exactly my problem :) > > I reckon it should be off by default because the threat posed by > this problem is IMHO small compared to some of the other standard > threats that are applicable to TCP. Plus this is a well-documented > feature so we can't be sure that someone somewhere isn't depending > on it. > > However, if it were off by default then there is very little value > in providing it at all since the same thing can be achived easily > through netfilter.
I understand your point of view.
> Anyway, let's leave it to Dave to make the decision.
At least, he has enough elements in his mailbox now :-)
Cheers, Willy
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |