Messages in this thread | | | Date | Mon, 13 Jun 2005 15:48:15 -0400 | From | Ananth N Mavinakayanahalli <> | Subject | Re: [patch 5/5] [kprobes] Tweak to the function return probe design |
| |
rusty.lynch@intel.com wrote:
Hi Rusty,
Thanks for doing this. However...
> + > + orig_ret_address = (unsigned long)ri->ret_addr; > + recycle_rp_inst(ri); > + > + if (orig_ret_address != (unsigned long) &kretprobe_trampoline) > + /* > + * This is the real return address. Any other > + * instances associated with this task are for > + * other calls deeper on the call stack > + */ > + break; > + } > + > + BUG_ON(!orig_ret_address); > + regs->nip = orig_ret_address; > + > + unlock_kprobes(); > + preempt_enable_no_resched(); ^^^^^^^
We don't need this here - on ppc64, we do a preempt_disable/enable in kprobe_exceptions_notify() and so this will cause a spurious preempt_enable().
Thanks, Ananth - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |