lkml.org 
[lkml]   [2005]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: 2.6.12-rc6-mm1
Date
On Sat, 11 Jun 2005 10:32, J.A. Magallon wrote:
> On 06.11, Con Kolivas wrote:
> > Here is what the patch _should_ have been. (*same warnings with this
> > patch about math demonstration and untested as should have been posted
> > with the earlier one*)
> >
> > + if (idle == NOT_IDLE || rq->nr_running > 1) {
> > + unsigned long prio_bias = 1;
> > + if (rq->nr_running)
> > + prio_bias = rq->prio_bias / rq->nr_running;
> > + source_load *= prio_bias;
> > + }
>
> Again... sorry, I don't try to be picky, just want to know if its worth or
> not...
>
> Would not be better something like:
>
> if (idle == NOT_IDLE || rq->nr_running > 1) {
> if (rq->nr_running)
> source_load = (source_load*rq->prio_bias) / rq->nr_running;
> }

I understand your concern, but by definition rq->nr_running will always be a
factor of rq->prio_bias so integer math should be fine. Either will do.

Cheers,
Con
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-06-11 02:55    [W:0.091 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site