Messages in this thread | | | From | Alexey Dobriyan <> | Subject | Re: [PATCH 1/2] Introduce tty_unregister_ldisc() | Date | Wed, 1 Jun 2005 19:22:52 +0400 |
| |
On Wednesday 01 June 2005 09:42, Christoph Hellwig wrote: > On Tue, May 31, 2005 at 05:28:11PM -0500, Paul Fulghum wrote: > > An unmodified ldisc driver (externally maintained) will continue to call > > tty_register_ldisc with NULL, but the new behavior will be to set the > > ldisc pointer to NULL but have LDISC_FLAG_DEFINED set. > > > > If you feel it is absolutely necessary to add this new function > > for cosmetic reasons, then leave the old behavior in place > > and make tty_unregister_ldisc a wrapper to tty_register_ldisc > > that uses a NULL pointer. > > Nah, we don't want to allow staying out of tree folks out of sync. Adding > a BUG_ON for ldisk beeing NULL is much more reasoable.
Why add BUG_ON?
tty_register_ldisc(N_FOO, NULL); ... tty_ldiscs[disc] = *new_ldisc; <= NULL - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |