Messages in this thread | | | Date | Wed, 1 Jun 2005 06:42:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] Introduce tty_unregister_ldisc() |
| |
On Tue, May 31, 2005 at 05:28:11PM -0500, Paul Fulghum wrote: > This patch is wrong. Please do not apply. > > An unmodified ldisc driver (externally maintained) will continue to call > tty_register_ldisc with NULL, but the new behavior will be to set the > ldisc pointer to NULL but have LDISC_FLAG_DEFINED set. > > If you feel it is absolutely necessary to add this new function > for cosmetic reasons, then leave the old behavior in place > and make tty_unregister_ldisc a wrapper to tty_register_ldisc > that uses a NULL pointer.
Nah, we don't want to allow staying out of tree folks out of sync. Adding a BUG_ON for ldisk beeing NULL is much more reasoable.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |