Messages in this thread | | | Date | Wed, 4 May 2005 11:44:47 +0200 (CEST) | Subject | Re: [PATCH] ds1337 2/3 | From | "Jean Delvare" <> |
| |
Hi Ladislav, hi all,
> i2c_transfer returns number of sucessfully transfered messages. Change > error checking to accordingly. (ds1337_set_datetime never returned > sucess)
I think you mean ds1337_GET_datetime, not ds1337_SET_datetime, never returned success?
Anyway I like the patch, it makes the driver treat the value returned by i2c_transfer() properly and makes the code overall more consistent.
Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |