lkml.org 
[lkml]   [2005]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] 2.6.11 fix PROMISC/bridging in TLAN driver
    Date
    From
    I'm re-sending this in the hope that someone will pick it up. I have
    made several attempts to contact the maintainer without success,
    although none recently.

    This has been a problem for me for ages. When using bridging, the driver
    is switched into promiscuous mode before the link init is complete. The
    init complete routine then resets the promisc bit on the card so the
    kernel still thinks the card is in promiscuous mode but the card isn't.
    doh.

    I think this bug only shows up in bridging when the bridge is started at
    boot time (or something else that sets promisc at the same time the card
    was started). If promisc is enabled later it works.

    Here's a trivial (and hopefully correct) patch that works for me. It
    just calls the promisc/multicast setup routine after init.

    James


    --- linux/drivers/net/tlan.c 2004-07-05 12:10:31.000000000 +1000
    +++ linux-2.4.26-xen0/drivers/net/tlan.c 2004-07-05
    11:43:48.000000000 +1000
    @@ -2378,6 +2378,7 @@
    TLan_SetTimer( dev, (10*HZ), TLAN_TIMER_FINISH_RESET );
    return;
    }
    + TLan_SetMulticastList(dev);

    } /* TLan_FinishReset */

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2005-05-04 02:50    [W:0.020 / U:32.680 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site