lkml.org 
[lkml]   [2005]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [2.6 patch] {,un}register_ioctl32_conversion should have been removed last month
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    Adrian Bunk wrote:
    > On Mon, May 02, 2005 at 05:30:52PM -0700, Andrew Morton wrote:
    >
    >>Adrian Bunk <bunk@stusta.de> wrote:
    >>
    >>>This removal should have happened last month.
    >>
    >>drivers/usb/misc/sisusbvga/sisusb.c will use these functions if someone
    >>defines SISUSB_OLD_CONFIG_COMPAT, so we need to agree to zap that code
    >>before I can merge this upstream.


    Why on earth should anyone #define something with "SISUSB" in the
    beginning, on a level that might be available in a usb driver?


    >
    > That's not a problem.
    >
    >
    > Quoting drivers/usb/misc/sisusbvga/sisusb.h:
    >
    > #ifdef CONFIG_COMPAT
    > #if LINUX_VERSION_CODE <= KERNEL_VERSION(2,6,10)
    > #include <linux/ioctl32.h>
    > #define SISUSB_OLD_CONFIG_COMPAT
    > #else
    > #define SISUSB_NEW_CONFIG_COMPAT
    > #endif
    > #endif
    >
    >
    > I decided not to drop the SISUSB_OLD_CONFIG_COMPAT code in my patch
    > because it seems Thomas is sharing this code between different kernel
    > versions, and a removal might make his life harder for no big win.


    Exactly. Thanks, Adrian.

    Thomas

    - --
    Thomas Winischhofer
    Vienna/Austria
    thomas AT winischhofer DOT net *** http://www.winischhofer.net
    twini AT xfree86 DOT org
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.0 (GNU/Linux)
    Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

    iD8DBQFCdyh+zydIRAktyUcRAgTLAKDJ7woebRDkqRS70aImI5c0y+fiyQCgyNqE
    8haWeqvcbbbCjYn607Xh51E=
    =ZaoZ
    -----END PGP SIGNATURE-----
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-03 09:34    [W:0.022 / U:34.080 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site