lkml.org 
[lkml]   [2005]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] PAL-M support fix for CX88 chipsets
On Tue, 03 May 2005 14:43:15 -0300 Mauro Carvalho Chehab wrote:

| >On Tue, 03 May 2005 09:48:24 -0300 Mauro Carvalho Chehab wrote:
| >
| >| This patch fixes PAL-M chroma subcarrier frequency (FSC) to its
| >| correct value of 3.5756115 MHz and adjusts horizontal total samples for
| >| PAL-M, according with formula Line Draw Time / (4*FSC), where Line Draw
| >| Time is 63.555 us.
| >| Without this patch, the Notch subcarrier filter was trying to
| >| capture using NTSC-M frequency, which is very close, but not equal. This
| >| could result in Black and White or miscolored frames.


This line:
+ static const unsigned int palm = 28604892;
begins with spaces, not a TAB.


+ if (V4L2_STD_PAL_M & norm->id) return palm;
Please only 1 space after the _M, and put the return on a
separate line.

Same comments for the next if/return.

And please clean up the next (final :) version with a
clean description and Signed-off-by: line.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-03 19:55    [W:0.039 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site