Messages in this thread | | | Subject | Re: 2.6.12-rc5-git3 fails compile -- acpi_boot_table_init | From | Alexander Nyberg <> | Date | Sun, 29 May 2005 21:17:40 +0200 |
| |
> > This is a neverending story > > > > linux/acpi.h contains empty declarations for acpi_boot_init() & > > acpi_boot_table_init() but they are nested inside #ifdef CONFIG_ACPI. > > > > So we'll have to #ifdef in arch/i386/kernel/setup.c: setup_arch() > > Wouldn't it be much nicer to just fix <linux/acpi.h> instead? Or, if you > really prefer this, then you should remove the now useless code from > acpi.h. In either case, this patch looks wrong. >
There's no question that the patch isn't the correct solution to the problem, it's a band-aid for a -rc5 kernel. The current acpi include system doesn't work very well.
Fixing it up for real with the risk of making some arch/config not compile for a long awaited 2.6.12 and having someone chase me with a spade isn't something i'm longing to try out. But if you insist...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |