lkml.org 
[lkml]   [2005]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] SATA NCQ support
On Fri, May 27 2005, Jeff Garzik wrote:
> Jens Axboe wrote:
> >On Fri, May 27 2005, Jeff Garzik wrote:
> >>I just noticed a bug -- When ata_scsi_qc_new() fails, the code should
> >>complete the command with queue-full, but does not.
> >>
> >> qc = ata_scsi_qc_new(ap, dev, cmd, done);
> >> if (!qc)
> >> return;
> >
> >
> >Indeed, looks like an old bug.
>
> Yep. If you are knocking around in that area, would you mind killing it
> for me? :)

Actually, I didn't look far enough up - ata_scsi_qc_new() already
completes the command with QUEUE_FULL if ata_qc_new_init() fails. So
there's no bug, but perhaps it would be cleaner to move it to
ata_scsi_translate instead?

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-27 10:37    [W:0.080 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site