lkml.org 
[lkml]   [2005]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [patch 4/8] irq code: Add coherence test for PREEMPT_ACTIVE
On Fri, May 27, 2005 at 03:06:09AM +0200, Blaisorblade wrote:
> On Friday 27 May 2005 02:38, blaisorblade@yahoo.it wrote:
> > After porting this fixlet to UML:
> >
> > http://linux.bkbits.net:8080/linux-2.5/cset@41791ab52lfMuF2i3V-eTIGRBbDYKQ
> >
> > , I've also added a warning which should refuse compilation with insane
> > values for PREEMPT_ACTIVE... maybe we should simply move PREEMPT_ACTIVE out
> > of architectures using GENERIC_IRQS.
> Ok, a grep shows that possible culprits (i.e. giving success to
> grep GENERIC_HARDIRQS arch/*/Kconfig, and using 0x4000000 as PREEMPT_ACTIVE,
> as given by grep PREEMPT_ACTIVE include/asm-*/thread_info.h) are (at a first
> glance): frv, sh, sh64.
>
Yeah, that's bogus for sh and sh64 anyways, this should do it.

It would be nice to move PRREMPT_ACTIVE so it isn't per-arch anymore,
there's not many users that use a different value (at least for the ones
using generic hardirqs, ia64 seems to be the only one?).

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

include/asm-sh/thread_info.h: needs update
include/asm-sh64/thread_info.h: needs update
Index: include/asm-sh/thread_info.h
===================================================================
--- 3ac9a34948049bff79a2b2ce49c0a3c84e35a748/include/asm-sh/thread_info.h (mode:100644)
+++ uncommitted/include/asm-sh/thread_info.h (mode:100644)
@@ -27,7 +27,7 @@

#endif

-#define PREEMPT_ACTIVE 0x4000000
+#define PREEMPT_ACTIVE 0x10000000

/*
* macros/functions for gaining access to the thread information structure
Index: include/asm-sh64/thread_info.h
===================================================================
--- 3ac9a34948049bff79a2b2ce49c0a3c84e35a748/include/asm-sh64/thread_info.h (mode:100644)
+++ uncommitted/include/asm-sh64/thread_info.h (mode:100644)
@@ -73,7 +73,7 @@

#define THREAD_SIZE 8192

-#define PREEMPT_ACTIVE 0x4000000
+#define PREEMPT_ACTIVE 0x10000000

/* thread information flags */
#define TIF_SYSCALL_TRACE 0 /* syscall trace active */[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2005-05-27 05:34    [W:0.050 / U:1.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site