Messages in this thread | | | Date | Thu, 26 May 2005 17:33:13 -0400 | From | Mark Lord <> | Subject | Re: [PATCH] libata: fix use-after-free during driver unload/unplug |
| |
Hi Jeff!
Jeff Garzik wrote: > > * add ->host_stop_prewalk() hook, use it in sata_qstor.c (hi Mark). > sata_qstor appears to require the host-stop-before-port-stop ordering > that existed prior to applying the attached patch.
Mmm.. I'm a little bit rusty here, but I don't think qstor cares about the order, so long as ports are marked with ATA_FLAG_PORT_DISABLED before invoking port_stop().
I've tried to allow disabling/enabling individual ports on-the-fly as needed, even though it never really happens in practice. So host_stop() kills the whole chip, whereas port_stop() I took to mean just one of the four SATA ports.
Cheers -- Mark Lord Real-Time Remedies Inc. mlord@pobox.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |