Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [patch 2/4] CPU hot-plug support for x86_64 | Date | Mon, 23 May 2005 21:37:07 +0200 |
| |
Hi,
On Monday, 23 of May 2005 18:38, Andi Kleen wrote: > On Fri, May 20, 2005 at 03:16:24PM -0700, Ashok Raj wrote: > > Experimental CPU hotplug patch for x86_64 > > ----------------------------------------- > > - Most of init code that needs to be there for hotplug marked now as __devinit > > (Didn't use cpuinit, simply because the main framework code in kernel > > is not the same way, just trying to be consistent) > > I dont like that. Can you keep it as __cpuinit please? e.g. > if cpuhot plug turns out to be a lot of code we could later > mark it free when we detect at boot the system does not support > cpu hotplug. With devinit that is pretty much impossible these days.
Please note that CPU hotplug will be necessary for swsusp on SMP systems (e.g. dual-core). It seems that currently __cpuinit <=> __init, so it's not quite suitable for this purpose.
Greets, Rafael
-- - Would you tell me, please, which way I ought to go from here? - That depends a good deal on where you want to get to. -- Lewis Carroll "Alice's Adventures in Wonderland" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |