Messages in this thread | | | Date | Thu, 19 May 2005 21:17:11 -0700 | From | chen Shang <> | Subject | Re: [PATCH] kernel <linux-2.6.11.10> kernel/sched.c |
| |
> Hi Chen, > With the added branch and the extra icache footprint, it isn't clear > that this would be a win. > > Also, you didn't say where your statistics came from (what workload). > > So you really need to start by demonstrating some increase on some workload. > > Also, minor comments on the patch: please work against mm kernels, > please follow > kernel coding style, and don't change schedstat output format in the > same patch > (makes it easier for those with schedstat parsing tools). > Hi Nick,
Thank you very much for your comments. This is the first time of my kernel hacking. I will reduce the lines of changes as much as possible. As regard to the statistics, there are just count, ie, the total number of priority-recalculations vs. the number of priority changed from the former recalculation.
Thanks again, -chen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |