lkml.org 
[lkml]   [2005]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] fix __mod_timer vs __run_timers deadlock.
    Date
    Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:

    > On Tue, 2005-05-03 at 00:50 +0200, Juergen Kreileder wrote:
    >> Andrew Morton <akpm@osdl.org> writes:
    >>
    >>> Oleg Nesterov <oleg@tv-sign.ru> wrote:
    >>>>
    >>>> When __mod_timer() changes timer's base it waits for the
    >>>> completion of timer->function. It is just stupid: the caller of
    >>>> __mod_timer() can held locks which would prevent completion of
    >>>> the timer's handler.
    >>>>
    >>>> Solution: do not change the base of the currently running timer.
    >>>
    >>> OK, fingers crossed. Juergen, it would be great if you could test
    >>> Oleg's patch sometime.
    >>
    >> I had one more lockup yesterday but that probably was caused by
    >> something else because Azureus is running fine for 24 hours now.
    >
    > Well, there may be other issues brought by this new timer code
    > though. I'm running G5s regulary without a lockup or anything for
    > weeks, so it would be interesting if you could try to find out
    > what's involved in that other lockup you had.

    Sure, if I find a way to reproduce it. It happened only once so far.


    BTW, xmon doesn't work for me. 'echo x > /proc/sysrq-trigger' gives
    me a :mon> prompt but I can't enter any commands.


    Juergen

    --
    Juergen Kreileder, Blackdown Java-Linux Team
    http://blog.blackdown.de/
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-03 03:44    [W:2.381 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site