Messages in this thread Patch in this message | | | Date | Thu, 19 May 2005 14:29:37 -0400 | From | Dave Jones <> | Subject | Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path |
| |
On Thu, May 19, 2005 at 11:16:21AM -0700, Tom Rini wrote: > On Thu, May 19, 2005 at 07:40:29PM +0200, Arjan van de Ven wrote: > > On Thu, 2005-05-19 at 09:43 -0700, Tom Rini wrote: > > > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is > > > not a defined symbol. Trivial fix is to EXPORT_SYMBOL hotplug_path. > > > > shouldn't this be a _GPL export since it's quite internal to linux... > > Doesn't matter to me. > > Signed-off-by: Tom Rini <trini@kernel.crashing.org> > > Index: lib/kobject_uevent.c > =================================================================== > --- c7d7a187a2125518e655dfeadffd38156239ffc3/lib/kobject_uevent.c (mode:100644) > +++ uncommitted/lib/kobject_uevent.c (mode:100644) > @@ -21,6 +21,7 @@ > #include <linux/string.h> > #include <linux/kobject_uevent.h> > #include <linux/kobject.h> > +#include <linux/module.h> > #include <net/sock.h> > > #define BUFFER_SIZE 1024 /* buffer for the hotplug env */ > @@ -178,6 +179,7 @@ > > #ifdef CONFIG_HOTPLUG > char hotplug_path[HOTPLUG_PATH_LEN] = "/sbin/hotplug"; > +EXPORT_SYMBOL_GPL(hotplug_path); > u64 hotplug_seqnum; > static DEFINE_SPINLOCK(sequence_lock);
ACK, I hit this a few days ago too, and did an identical patch for the Fedora kernel. In addition, there was also this one..
Signed-off-by: Dave Jones <davejredhat.com>
WARNING: /usr/src/build/566509-ppc64iseries/install/lib/modules/2.6.11-1.1311_FC4/kernel/drivers/input/input.ko needs unknown symbol add_input_randomness
--- linux-2.6.11/drivers/char/random.c~ 2005-05-14 16:42:24.000000000 -0400 +++ linux-2.6.11/drivers/char/random.c 2005-05-14 16:42:46.000000000 -0400 @@ -646,6 +646,7 @@ extern void add_input_randomness(unsigne add_timer_randomness(&input_timer_state, (type << 4) ^ code ^ (code >> 4) ^ value); } +EXPORT_SYMBOL_GPL(add_input_randomness); void add_interrupt_randomness(int irq) {
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |