Messages in this thread | | | Date | Wed, 18 May 2005 09:11:43 -0700 | From | Greg KH <> | Subject | Re: [PATCH] Driver Core: remove driver model detach_state |
| |
On Wed, May 18, 2005 at 12:13:11PM +0200, Kay Sievers wrote: > On Tue, 2005-05-17 at 15:12 -0700, Greg KH wrote: > > [PATCH] Driver Core: remove driver model detach_state > > > > The driver model has a "detach_state" mechanism that: > > > > - Has never been used by any in-kernel drive; > > - Is superfluous, since driver remove() methods can do the same thing; > > - Became buggy when the suspend() parameter changed semantics and type; > > - Could self-deadlock when called from certain suspend contexts; > > - Is effectively wasted documentation, object code, and headspace. > > > > This removes that "detach_state" mechanism; net code shrink, as well > > as a per-device saving in the driver model and sysfs. > > Huh, we need to fix a lot of userspace programs now. libsysfs depends on > finding that file, udev waits for this to recognize sysfs population. I > will go fix this where I know this is used, but be prepared for stupid > failures... :)
Yeah, good catch, so that's why udev stoped working for me on some custom rules...
Anyway, I think it was pretty stupid for libsysfs to depend on that file, I'll work on fixing that up. Luckily, no one uses libsysfs :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |