Messages in this thread | | | Date | Tue, 17 May 2005 19:52:38 -0700 (PDT) | From | Christoph Lameter <> | Subject | Re: [PATCH] NUMA aware allocation of transmit and receive buffers for e1000 |
| |
On Tue, 17 May 2005, Andrew Morton wrote:
> Christoph Lameter <christoph@graphe.net> wrote: > > > > NUMA awareness for the e1000 driver. Allocate transmit and receive buffers > > on the node of the device. > > Hast thou any benchmarking results?
Yes, your honor. Just a second .... The patch has been around for a long time.
No benchmarks results in my email archive. Would need to talk to some folks tomorrow and maybe we would have to run some new benchmarks.
> > - txdr->buffer_info = vmalloc(size); > > + txdr->buffer_info = kmalloc_node(size, GFP_KERNEL, node); > > How come that this is safe to do
Because physically contiguous memory is usually better than virtually contiguous memory? Any reason that physically contiguous memory will break the driver?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |