Messages in this thread | | | Subject | Re: [PATCH 2.6.12-rc4-mm2] perfctr: x86 update with K8 multicore fixes, take 2 | From | Andi Kleen <> | Date | Wed, 18 May 2005 00:23:37 +0200 |
| |
Mikael Pettersson <mikpe@csd.uu.se> writes:
> +#ifdef CONFIG_SMP > +static void __init k8_multicore_init(void) > +{ > + cpumask_t non0cores; > + int i; > + > + cpus_clear(non0cores); > + for(i = 0; i < NR_CPUS; ++i) { > + cpumask_t cores = cpu_core_map[i]; > + int core0 = first_cpu(cores); > + if (core0 >= NR_CPUS) > + continue; > + cpu_clear(core0, cores); > + cpus_or(non0cores, non0cores, cores); > + } > + if (cpus_empty(non0cores)) > + return; > + k8_is_multicore = 1;
That is still far too complicated. Just use current_cpu_data->x86_num_cores > 1 That is simple enough that you don't need the ugly variable.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |