Messages in this thread | | | Date | Tue, 17 May 2005 14:51:37 -0700 | From | Pete Zaitcev <> | Subject | Re: Oops on CF removal and "convert device drivers to driver-model" |
| |
On Tue, 17 May 2005 23:17:04 +0200, Pozsár Balázs <pozsy@uhulinux.hu> wrote:
> On Sat, May 14, 2005 at 01:50:19PM -0700, Pete Zaitcev wrote: > > @@ -1138,7 +1133,8 @@ static int idescsi_attach(ide_drive_t *d > > idescsi->host = host; > > idescsi->disk = g; > > g->private_data = &idescsi->driver; > > - err = ide_register_subdriver(drive, &idescsi_driver); > > + ide_register_subdriver(drive, &idescsi_driver); > > + err = 0; > > if (!err) { > > idescsi_setup (drive, idescsi); > > g->fops = &idescsi_ops; > > !err cannot be true here, so this seems buggy.
Indeed.
Unfortunately, Andrew's scripts notified me that he added the patch to his tree, so I'd need to wait for a turnaround before a fix-over-fix.
-- Pete - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |