lkml.org 
[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/8] ppc64: add a watchdog driver for rtas
    Arnd Bergmann wrote:
    > +static volatile int wdrtas_miscdev_open = 0;
    ...
    > +static int
    > +wdrtas_open(struct inode *inode, struct file *file)
    > +{
    > + /* only open once */
    > + if (xchg(&wdrtas_miscdev_open,1))
    > + return -EBUSY;

    The volatile and xchg strike me as an obscure method for ensuring only
    one process at a time can open this file. Any reason a semaphore
    couldn't be used?

    > +static int
    > +wdrtas_close(struct inode *inode, struct file *file)
    > +{
    > + /* only stop watchdog, if this was announced using 'V' before */
    > + if (wdrtas_expect_close == WDRTAS_MAGIC_CHAR)
    > + wdrtas_timer_stop();
    > + else {
    > + printk("wdrtas: got unexpected close. Watchdog "
    > + "not stopped.\n");

    printk's need a valid log level specified. There are several in this
    file that lack them.


    Nathan
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-17 22:45    [W:0.028 / U:98.908 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site