lkml.org 
[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] timers fixes/improvements
On Tue, May 17, 2005 at 08:38:45AM -0700, Sy, Dely L wrote:
> On Friday, May 13, 2005 3:36 PM, Greg KH wrote:
> > > The definition of GET_INDEX is suspect:
> > >
> > > #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
> b)
> > >
> > > should this not be
> > >
> > > #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) +
> \
> > > ((b) & 7))
> > >
> > > ?
> >
> > Dely, any thoughts about this, or know who would know about it?
>
> Greg,
>
> I looked at the code and talked with Steve on this. The fix is correct;
> i.e. b has to be masked with 7. Would Christoph or you send out a
> patch for the fix or would you like us to do so? Thanks for finding out
> the problem.

If you would send me a patch (or someone), that I could apply, I would
appreciate it.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-17 18:10    [W:0.295 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site