lkml.org 
[lkml]   [2005]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Fix root hole in pktcdvd
    On Mon, May 16, 2005 at 09:37:49PM -0700, Greg KH wrote:
    > ioctl_by_bdev may only be used INSIDE the kernel. If the "arg" argument
    > refers to memory that is accessed by put_user/get_user in the ioctl
    > function, the memory needs to be in the kernel address space (that's the
    > set_fs(KERNEL_DS) doing in the ioctl_by_bdev). This works on i386 because
    > even with set_fs(KERNEL_DS) the user space memory is still accessible with
    > put_user/get_user. That is not true for s390. In short the ioctl
    > implementation of the pktcdvd device driver is horribly broken.

    Same comment as for previous patch. I'll take a look at that sucker,
    it might happen to be OK, seeing that most of the bdev ->ioctl() instances
    ignore file argument and we might get away with passing odd stuff to
    anything that could occur here.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-05-17 07:08    [W:0.020 / U:0.180 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site