lkml.org 
[lkml]   [2005]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/pnp/: possible cleanups
On Tue, May 17, 2005 at 02:08:53AM +0200, Adrian Bunk wrote:

Hi Adrian,

I'll apply this patch if you comment out or use "#if 0" on the exported
symbols. Also do not remove isapnp_read_byte or pnp_auto_config_dev because
they are part of the device driver API. I would like you to only target the
protocol API. I'll have the time to seriously work on features like modular
isapnp in about a week.

Thanks,
Adam


>
> This patch contains the following possible cleanups:
> - make needlessly global code static
> - #if 0 the following unused global function:
> - core.c: pnp_remove_device
> - remove the following unneeded EXPORT_SYMBOL's:
> - card.c: pnp_add_card
> - card.c: pnp_remove_card
> - card.c: pnp_add_card_device
> - card.c: pnp_remove_card_device
> - card.c: pnp_add_card_id
> - core.c: pnp_register_protocol
> - core.c: pnp_unregister_protocol
> - core.c: pnp_add_device
> - core.c: pnp_remove_device
> - pnpacpi/core.c: pnpacpi_protocol
> - driver.c: pnp_add_id
> - isapnp/core.c: isapnp_read_byte
> - manager.c: pnp_auto_config_dev
> - resource.c: pnp_register_dependent_option
> - resource.c: pnp_register_independent_option
> - resource.c: pnp_register_irq_resource
> - resource.c: pnp_register_dma_resource
> - resource.c: pnp_register_port_resource
> - resource.c: pnp_register_mem_resource
>
> Note that this patch #if 0's exactly one functions and removes no
> functions. Most it does is the removal of EXPORT_SYMBOL's, so if any
> modular code will use any of them, re-adding will be trivial.
>
> Modular ISAPnP might be interesting in some cases, but this is more
> legacy code. If someone would work on it to sort all the issues out
> (starting with the point that most users of __ISAPNP__ will have to be
> fixed) re-adding the required EXPORT_SYMBOL's won't be hard for him.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-17 02:39    [W:0.051 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site