lkml.org 
[lkml]   [2005]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] timers fixes/improvements
On Wed, May 11, 2005 at 08:12:16AM -0700, Christoph Lameter wrote:
> We found that this has nothing to do with the timer patches. There is a
> scribble in pcie_rootport_aspm_quirk that overwrites ptype_all.

Ick.

> quirk_aspm_offset[GET_INDEX(pdev->device, dev->devfn)]= cap_base + 0x10;
>
> does the evil deed. The array offset calculated by GET_INDEX is out of
> bounds.
>
> The definition of GET_INDEX is suspect:
>
> #define GET_INDEX(a, b) (((a - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + b)
>
> should this not be
>
> #define GET_INDEX(a, b) ((((a) - PCI_DEVICE_ID_INTEL_MCH_PA) << 3) + \
> ((b) & 7))
>
> ?

Dely, any thoughts about this, or know who would know about it?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-14 01:05    [W:0.066 / U:4.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site