Messages in this thread Patch in this message | | | Subject | Re: [PATCH] namespace.c: fix bind mount from foreign namespace | From | Ram <> | Date | Fri, 13 May 2005 10:29:16 -0700 |
| |
On Fri, 2005-05-13 at 10:17, Miklos Szeredi wrote: > > > Bind mount from a foreign namespace results in > > > > ... -EINVAL > > Wrong answer. Look again, you wrote the code, so you _should_ know ;)
I guess Al agrees that bind mount from foreign namespace must be disallowed.
Which means what Jamie pointed to was right. Attached the patch which fixes it.
> > Miklos > - > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --- /home/linux/views/linux-2.6.12-rc4/fs/namespace.c 2005-05-06 23:22:29.000000000 -0700 +++ 2.6.12-rc4/fs/namespace.c 2005-05-13 10:17:19.000000000 -0700 @@ -633,7 +633,7 @@ static int do_loopback(struct nameidata down_write(¤t->namespace->sem); err = -EINVAL; - if (check_mnt(nd->mnt) && (!recurse || check_mnt(old_nd.mnt))) { + if (check_mnt(nd->mnt) && check_mnt(old_nd.mnt)) { err = -ENOMEM; if (recurse) mnt = copy_tree(old_nd.mnt, old_nd.dentry); | |