Messages in this thread | | | Date | Wed, 11 May 2005 00:19:02 -0700 | From | Greg KH <> | Subject | Re: [patch 2.6.12-rc3] dell_rbu: New Dell BIOS update driver |
| |
On Tue, May 10, 2005 at 05:05:20PM -0500, Abhay Salunke wrote: > +static struct bin_attribute rbudata_attr = { > + .attr = {.name = "rbudata", .owner = THIS_MODULE, .mode = 0644}, > + .read = read_rbu_data, > + .write = write_rbu_data, > +}; > + > +static struct bin_attribute rbudatasize_attr = { > + .attr = { .name = "rbudatasize", .owner = THIS_MODULE, .mode = 0644 }, > + .read = read_rbu_data_size, > + .write= write_rbu_data_size, > +}; > + > +static struct bin_attribute packetdatasize_attr = { > + .attr = { .name = "packetdatasize", .owner = THIS_MODULE, .mode = 0644 }, > + .read = read_packet_data_size, > + .write= write_packet_data_size, > +}; > + > +static struct bin_attribute packetdata_attr = { > + .attr = { .name = "packetdata", .owner = THIS_MODULE, .mode = 0644 }, > + .read = read_rbu_packet_data, > + .write= write_rbu_packet_data, > +};
I can understand having the data use the sysfs binary attribute, but do not do this for the size files. Please just use a normal attribute for them, the binary ones are _only_ for blobs of data that are not interpreted by the kernel.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |