lkml.org 
[lkml]   [2005]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Software suspend and recalc sigpending bug fix
On St 11-05-05 19:20:47, Kirill Korotaev wrote:
> This patch fixes recalc_sigpending() to work correctly
> with tasks which are being freezed. The problem is that
> freeze_processes() sets PF_FREEZE and TIF_SIGPENDING
> flags on tasks, but recalc_sigpending() called from
> e.g. sys_rt_sigtimedwait or any other kernel place
> will clear TIF_SIGPENDING due to no pending signals queued
> and the tasks won't be freezed until it recieves a real signal
> or freezed_processes() fail due to timeout.
>
> Signed-Off-By: Kirill Korotaev <dev@sw.ru>
> Signed-Off-By: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>

This should fix our problems with mysqld, right? Yes, patch looks good
(modulo missing whitespace around &)). I'll apply it to my tree. (Or
andrew, if you prefer, just take it...
Pavel

> --- ./kernel/signal.c.freezesigrec 2005-05-10 16:10:40.000000000 +0400
> +++ ./kernel/signal.c 2005-05-10 18:10:08.000000000 +0400
> @@ -212,6 +212,7 @@ static inline int has_pending_signals(si
> fastcall void recalc_sigpending_tsk(struct task_struct *t)
> {
> if (t->signal->group_stop_count > 0 ||
> + (t->flags&PF_FREEZE) ||
> PENDING(&t->pending, &t->blocked) ||
> PENDING(&t->signal->shared_pending, &t->blocked))
> set_tsk_thread_flag(t, TIF_SIGPENDING);


--
Boycott Kodak -- for their patent abuse against Java.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-11 20:12    [W:0.032 / U:1.944 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site