Messages in this thread | | | Date | Sun, 1 May 2005 16:23:30 +0200 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups |
| |
On Tue, Apr 19, 2005 at 09:53:48AM +0200, Gerd Knorr wrote:
> > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump > > That's a debug helper function, please don't drop it. #if 0 might be > ok, not sure though, the tveeprom module is also used by a out-of-kernel > driver (ivtv). Otherwise the patch looks fine to me.
As the comment says, my patch does #if 0 the function.
> Gerd
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |