lkml.org 
[lkml]   [2005]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
On Tue, Apr 19, 2005 at 09:53:48AM +0200, Gerd Knorr wrote:

> > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
>
> That's a debug helper function, please don't drop it. #if 0 might be
> ok, not sure though, the tveeprom module is also used by a out-of-kernel
> driver (ivtv). Otherwise the patch looks fine to me.

As the comment says, my patch does #if 0 the function.

> Gerd

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-05-01 16:26    [W:0.044 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site