lkml.org 
[lkml]   [2005]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
David Howells wrote:
> Hugh Dickins <hugh@veritas.com> wrote:
>
>
>>Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no
>>other syscall refers to it), unnecessary (sys_mincore loops over vmas
>>further down) and incorrect (misses user addresses in ARM's first pgd).
>
>
> You should make it use FIRST_USER_ADDRESS instead. This check allows NULL
> pointers and suchlike to be weeded out before having to take the semaphore.
>

I'm not sure whether it is worth keeping the singular special
case here to slightly speed up what would probably be a bug in
a userspace program.

--
SUSE Labs, Novell Inc.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-07 16:36    [W:0.033 / U:27.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site