Messages in this thread | | | Date | Wed, 6 Apr 2005 15:43:16 -0700 | From | Andrew Morton <> | Subject | Re: [03/08] fix ia64 syscall auditing |
| |
Ryan Anderson <ryan@michonline.com> wrote: > > On Tue, Apr 05, 2005 at 01:49:18PM -0700, Greg KH wrote: > > On Tue, 2005-04-05 at 13:27 -0700, David Mosberger wrote: > > > >>>>> On Tue, 5 Apr 2005 09:46:48 -0700, Greg KH <gregkh@suse.de> said: > > > > > > Greg> -stable review patch. If anyone has any objections, please > > > Greg> let us know. > > > > > > Nitpick: the patch introduces trailing whitespace. > > > > Sorry about that, I've removed it from the patch now. > > > > > Why doesn't everybody use emacs and enable show-trailing-whitespace? ;-) > > > > Because some of us use vim and ":set list" to see it, when we remember > > to... :) > > Try adding this to your .vimrc: > > highlight WhitespaceEOL ctermbg=red guibg=red > match WhitespaceEOL /\s\+$/ > > Then you'll have to resist the urge to fix whitespace issues instead of > not seeing them at all. >
Yeah, that's a risk. But gratuitous trailing whitespace changes shouldn't cause a lot of downstream problems due to `patch -l'.
What I do is to ensure that we never _add_ trailing whitespace. So anything which matches
^+.*[tab or space]$
gets trimmed. My theory is that after 10 years of this, all the trailing whitespace will be gone. Problem is, I also see the hundreds of lines of code in the bk patches which add trailing whitespace :(
Larry sent me a little bk script which would spam the user if they tried to commit something which adds trailing whitespace, but maybe that's a bit academic right now.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |