lkml.org 
[lkml]   [2005]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH][RFC] disable built-in modules V2
    On Apr 6, 2005 4:28 PM, Malcolm Rowe <malcolm-linux@farside.org.uk> wrote:
    > Magnus Damm writes:
    > > And I guess the idea of replacing the initcall pointer with NULL will
    > > work both with and without function descriptors, right? So we should
    > > be safe on IA64 and PPC64.
    >
    > I think so, though I don't really know a great deal about this area.
    >
    > An IA64 descriptor is of the form { &code, &data_context }, and a function
    > pointer is a pointer to such a descriptor. Presumably, setting a function
    > pointer to NULL will either end up setting the pointer-to-descriptor to NULL
    > or the code pointer to NULL, but either way, I would expect the 'if
    > (!*call)' comparison to work as intended.
    >
    > Best thing would be to get someone on IA64 and/or PPC64 to check this for
    > you.

    I agree. Do we have any friendly IA64/PPC64 user out there?

    > Also might be worth checking that the patch works as intended with
    > CONFIG_MODULES=n (assuming you haven't already).

    The code works both with CONFIG_MODULES set to "y" and unset.

    Thanks,

    / magnus
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-07 00:20    [W:0.021 / U:2.432 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site