lkml.org 
[lkml]   [2005]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 5/5] sched: consolidate sbe sbf

* Nick Piggin <nickpiggin@yahoo.com.au> wrote:

> 5/5
>
> Any ideas about what to do with schedstats?
> Do we really need balance on exec and fork as seperate
> statistics?

> Consolidate balance-on-exec with balance-on-fork. This is made easy
> by the sched-domains RCU patches.
>
> As well as the general goodness of code reduction, this allows
> the runqueues to be unlocked during balance-on-fork.
>
> schedstats is a problem. Maybe just have balance-on-event instead
> of distinguishing fork and exec?
>
> Signed-off-by: Nick Piggin <nickpiggin@yahoo.com.au>

looks good.

Acked-by: Ingo Molnar <mingo@elte.hu>

while the code is now consolidated, i think we still need the separate
fork/exec stats for schedstat. We have 3 conceptual ways to start off a
new context: fork(), pthread_create() and execve(), and applications use
them in different patterns. We have different flags and tuning
parameters for two of them (which might have to become 3, i'm not
entirely convinced we'll be able to ignore the 'process vs. thread'
condition in wake_up_new_task(), STREAM is a really bad example in that
sense), so we need 2 (or 3) separate stats.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:0.068 / U:5.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site