[lkml]   [2005]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: 2.6.12-rc2-mm1
    Btw, some more comments on the 32bit compat code in drm:

    - instead of set_fs & co and passing kernel addresses to drm_ioctl
    please use compat_alloc_user_space()

    - this:

    +ifeq ($(CONFIG_COMPAT),y)
    +drm-objs += drm_ioc32.o
    +radeon-objs += radeon_ioc32.o

    should be written as

    drm-$(CONFIG_COMPAT) += drm_ioc32.o
    radeon-$(CONFIG_COMPAT) += radeon_ioc32.o

    and everything else should use foo-y instead of foo-objs

    - the magic CONFIG_COMPAT changes for SHM handles should only be done when
    a module is set. CONFIG_COMPAT is set for mostly 64bit systems that can
    run 32bit code and drm shouldn't behave differently just because we can
    run 32bit code.
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2005-04-06 13:31    [W:0.018 / U:20.260 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site