Messages in this thread | | | Subject | Re: [RFC 5/6]clean cpu state after hotremove CPU | From | Li Shaohua <> | Date | Tue, 05 Apr 2005 09:06:34 +0800 |
| |
On Tue, 2005-04-05 at 03:11, Zwane Mwaikambo wrote: > On Mon, 4 Apr 2005, Li Shaohua wrote: > > > Clean up all CPU states including its runqueue and idle thread, > > so we can use boot time code without any changes. > > Note this makes /sys/devices/system/cpu/cpux/online unworkable. > > > > #ifdef CONFIG_HOTPLUG_CPU > > #include <asm/nmi.h> > > + > > +#ifdef CONFIG_STR_SMP > > +extern void cpu_exit_clear(int); > > +#endif > > Perhaps change that ifdef to denote something which clearly shows that its > physical hotplug as we'll need this for other users too. Ok.
> > +#ifdef CONFIG_STR_SMP > > +extern void do_exit_idle(void); > > +extern void cpu_uninit(void); > > +void cpu_exit_clear(int cpu) > > +{ > > + int sibling; > > + cpucount --; > > Is that protected by the cpu_control semaphore? cpu_exit_clear is called before the dead CPU ack CPU_DEAD, so it's finished before __cpu_die returns, which is protected by cpu_control. Maybe I should add comments for it.
Thanks, Shaohua
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |