lkml.org 
[lkml]   [2005]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 2.6.12-rc3-mm1
    On Fri, Apr 29, 2005 at 11:16:53PM -0700, Andrew Morton wrote:
    >...
    > Changes since 2.6.12-rc2-mm3:
    >...
    > +x86-x86_64-deferred-handling-of-writes-to-proc-irq-xx-smp_affinitypatch-added-to-mm-tree.patch
    >
    > x86_64 updates
    >...


    This patch contains at least two bugs:


    The static inline set_irq_info() is not available
    for CONFIG_GENERIC_PENDING_IRQ=n, resulting in the following warning:

    <-- snip -->

    ...
    CC arch/i386/kernel/io_apic.o
    arch/i386/kernel/io_apic.c: In function `set_ioapic_affinity_irq':
    arch/i386/kernel/io_apic.c:251: warning: implicit declaration of function `set_irq_info'
    ...

    <-- snip -->


    The second bug is that although irq.h defines set_irq_info() as a static
    inline, this patch adds an empty function to kernel/irq/manage.c .

    The second bug shadows the first bug, but both have to be fixed.


    cu
    Adrian

    BTW: This patch is not in anyway x86_64 specific.

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-30 16:25    [W:2.713 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site