lkml.org 
[lkml]   [2005]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Deferred handling of writes to /proc/irq/xx/smp_affinity
On Wed, 27 Apr 2005, Ashok Raj wrote:

> Hi Andrew and all
>
> It is safe to re-program rte entries in ioapic only when an intr is pending.
> Existing code does this incorrectly by reprogamming rte entries immediatly
> when a value is written to /proc/irq/xx/smp_affinity. IRQ_BALANCE code in
> kernel does this right, but /proc/irq needs to be handled the same way so that
> user mode irq_balancer wont lock up systems or loose interrupts in the race.
>
> This is already fixed in ia64, introduced for i386 and x86_64.
>
> since this touches 3 arch's managing in -mm for trial would be best to make
> sure nothing is broken, before considering for main line.

Ashok, thanks for doing this, i only have minor nitpicks, can we avoid
the wrapper for irq_desc and just index it directly? And could we use
static inline functions for MOVE_IRQ and SET_IRQ_INFO macros and use nop
functions where required.

Thanks,
Zwane

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-28 08:49    [W:0.195 / U:0.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site