Messages in this thread | | | Date | Mon, 25 Apr 2005 23:47:16 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH] i386: fix hpet for systems that don't support legacy replacement (v. A0) |
| |
On Mon, 25 Apr 2005, john stultz wrote:
> Andrew, > Currently the i386 HPET code assumes the entire HPET implementation > from the spec is present. This breaks on boxes that do not implement the > optional legacy timer replacement functionality portion of the spec. > > This patch, which is very similar to my x86-64 patch for the same issue, > fixes the problem allowing i386 systems that cannot use the HPET for the > timer interrupt and RTC to still use the HPET as a time source. I've > tested this patch on a system systems without HPET, with HPET but > without legacy timer replacement, as well as HPET with legacy timer > replacement. > > There has been no changes since this patch was sent out to lkml for > review. >
Tiny, tiny nit :
> - if (is_hpet_enabled()){ > + if (is_hpet_enabled() && hpet_use_timer){ ^^-- space here?
-- Jesper Juhl
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |