lkml.org 
[lkml]   [2005]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] PCI: Add pci shutdown ability
    On Mon, Apr 25, 2005 at 10:42:07PM +0200, Pavel Machek wrote:
    > Hi!
    >
    > > Well it seems that people are starting to want to hook the reboot
    > > notifier, or the device shutdown facility in order to properly shutdown
    > > pci drivers to make kexec work nicer.
    > >
    > > So here's a patch for the PCI core that allows pci drivers to now just
    > > add a "shutdown" notifier function that will be called when the system
    > > is being shutdown. It happens just after the reboot notifier happens,
    > > and it should happen in the proper device tree order, so everyone should
    > > be happy.
    > >
    > > Any objections to this patch?
    >
    > Yes.
    >
    > I believe it should just do suspend(PMSG_SUSPEND) before system
    > shutdown. If you think distintion between shutdown and suspend is
    > important (I am not 100% convinced it is), we can just add flag
    > saying "this is system shutdown".

    Then why even have the device_shutdown() call and notifier in the struct
    device_driver?

    > Actually this patch should be in the queue somewhere... We had it in
    > suse trees for a long time, and IMO it can solve problem easily.
    >
    > Pavel
    >
    > --- clean-git/kernel/sys.c 2005-04-23 23:21:55.000000000 +0200
    > +++ linux/kernel/sys.c 2005-04-24 00:20:47.000000000 +0200
    > @@ -404,6 +404,7 @@
    > case LINUX_REBOOT_CMD_HALT:
    > notifier_call_chain(&reboot_notifier_list, SYS_HALT, NULL);
    > system_state = SYSTEM_HALT;
    > + device_suspend(PMSG_SUSPEND);
    > device_shutdown();

    Again, why keep device_shutdown() around at all then?

    thanks,

    greg k-h
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-25 23:10    [W:0.022 / U:0.080 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site