Messages in this thread | | | Date | Mon, 25 Apr 2005 20:10:04 +0200 (CEST) | From | Jesper Juhl <> | Subject | Re: [PATCH 2/7] dlm: communication |
| |
On Mon, 25 Apr 2005, David Teigland wrote:
> > Inter-node communiction using SCTP. This level is not aware of locks or > resources or other dlm objects, only data buffers. These functions also > batch (and extract) lots of small messages bound for one node into larger > chunks. > > Signed-Off-By: Dave Teigland <teigland@redhat.com> > Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com> > > --- > > +struct connection { > + struct socket * sock; > + unsigned long flags; > + struct page * rx_page; > + atomic_t waiting_requests; > + struct cbuf cb; > +};
type * varname; is not very pretty. The prefered form is generally type *varname; Several instances of this in various places.
> +static void init_failed(void) > +{ > + int i; > + struct nodeinfo *ni; > + > + for (i=1; i<=max_nodeid; i++) { Nitpicking, but how about a few spaces? for (i = 1; i <= max_nodeid; i++) { makes it more readable IMHO.
> +#if 0 > +static int lowcomms_close(int nodeid) > +{
Ehh, why try and merge code that's not active? Why not leave it out and submit a patch later to add it if it is needed later?
-- Jesper Juhl
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |