Messages in this thread | | | Date | Sat, 2 Apr 2005 16:58:09 +0200 | From | Ingo Molnar <> | Subject | Re: [RFC][PATCH] timers fixes/improvements |
| |
* Andrew Morton <akpm@osdl.org> wrote:
> Oleg Nesterov <oleg@tv-sign.ru> wrote: > > > > +void fastcall init_timer(struct timer_list *timer) > > +{ > > + timer->entry.next = NULL; > > + timer->_base = &per_cpu(tvec_bases, > > + __smp_processor_id()).t_base; > > + timer->magic = TIMER_MAGIC; > > +} > > __smp_processor_id() is not implemented on all architectures. I'll switch > this to _smp_processor_id(). > > The smp_processor_id() stuff is all rather a twisty maze (looks at Ingo).
_smp_processor_id() is fine in this case - we pick a CPU at init_timer() time, but we dont need to be non-preemptible when we do so.
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |