Messages in this thread Patch in this message | | | Date | Tue, 19 Apr 2005 14:47:58 -0400 | From | Martin Hicks <> | Subject | Re: [PATCH] pgtables: fix GFP_KERNEL allocation with preempt disabled |
| |
On Tue, Apr 19, 2005 at 11:30:44AM -0700, David S. Miller wrote: > > I think you should really drop the preempt disable during this allocation > instead, that's what we do in the sparc64 quicklist code. >
Okay, here's an updated patch.
Hi Andrew,
This is a fix to the pgtable_quicklist code. There is a GFP_KERNEL allocation in pgtable_quicklist_alloc(), which spews the usual warnings if the kernel is under heavy VM pressure and the reclaim code is invoked. re-enable preempt before we allocate the new page.
This patch is against 2.6.12-rc2-mm2
Signed-off-by: Martin Hicks <mort@sgi.com>
pgalloc.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6.12-rc2.wk/include/asm-ia64/pgalloc.h =================================================================== --- linux-2.6.12-rc2.wk.orig/include/asm-ia64/pgalloc.h 2005-04-19 10:13:16.000000000 -0700 +++ linux-2.6.12-rc2.wk/include/asm-ia64/pgalloc.h 2005-04-19 11:40:09.000000000 -0700 @@ -49,12 +49,12 @@ static inline void *pgtable_quicklist_al pgtable_quicklist = (unsigned long *)(*ret); ret[0] = 0; --pgtable_quicklist_size; + preempt_enable(); } else { + preempt_enable(); ret = (unsigned long *)__get_free_page(GFP_KERNEL | __GFP_ZERO); } - preempt_enable(); - return ret; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |