lkml.org 
[lkml]   [2005]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC 1 of 9] patches to add diskdump functionality to block layer
From
Date
On Mon, 2005-04-18 at 10:36 -0500, mike.miller@hp.com wrote:
> +
> +/*
> + * Extended block operations for dump for preserving binary compatibility.
> + */
> +struct block_dump_ops {
> + int (*sanity_check)(void *device);
> + int (*rw_block)(void *device, int rw, unsigned long dump_block_nr, void *buf, int len, unsigned long start_sect, unsigned long nr_sects);
> + int (*quiesce)(void *device);
> + int (*shutdown)(void *device);
> +};

this looks wrong. In linux we don't care about module ABI, and just go
for the clean solution instead! (eg in this case, just put the methods
in the block dev ops)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-18 17:51    [W:0.197 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site