lkml.org 
[lkml]   [2005]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [CHECKER] possible missing capability check in ioctl function, drivers/net/cris/eth_v10.c, kernel 2.6.11
* Ted Kremenek (kremenek@cs.stanford.edu) wrote:
> In several network drivers that handle the ioctl command SIOCSMIIREG
> (writes a register on the network card) most implementations check for
> the CAP_NET_ADMIN capability. Several drivers use the function
> "generic_mii_ioctl" to process this command (defined in
> drivers/net/mii.c). In mii.c, we see:

This, to me, looks like the device specific (or generic_mii_ioctl)
capability test winds up being redundant. The top-level checks
capabilities already in net/dev/core.c::dev_ioctl(). So, while there's
some room for cleanup, I don't think this is an acutal bug.

thanks,
-chris
--
Linux Security Modules http://lsm.immunix.org http://lsm.bkbits.net
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-15 18:04    [W:0.950 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site