lkml.org 
[lkml]   [2005]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] sched: fix active load balance

* Siddha, Suresh B <suresh.b.siddha@intel.com> wrote:

> - for_each_domain(target_cpu, sd) {
> + for_each_domain(target_cpu, sd)
> if ((sd->flags & SD_LOAD_BALANCE) &&
> - cpu_isset(busiest_cpu, sd->span)) {
> - sd = tmp;
> + cpu_isset(busiest_cpu, sd->span))
> break;
> - }
> - }

hm, the right fix i think is to do:

for_each_domain(target_cpu, tmp) {
if ((tmp->flags & SD_LOAD_BALANCE) &&
cpu_isset(busiest_cpu, tmp->span)) {
sd = tmp;
break;
}
}

because when balancing we want to match the widest-scope domain, not the
first one. The s/tmp/sd thing was a typo i suspect.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-13 22:13    [W:0.045 / U:1.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site