Messages in this thread | | | Date | Wed, 13 Apr 2005 03:53:00 +0100 | From | Al Viro <> | Subject | Re: [2.6 patch] drivers/net/pcmcia/nmclan_cs.c: fix a check after use |
| |
On Wed, Apr 13, 2005 at 04:17:34AM +0200, Adrian Bunk wrote: > This patch fixes a check after use found by the Coverity checker.
Again, check is a pure BS. Argument passed to this sucker comes from ->Instance of the same struct that had ->Handler equal to mace_interrupt(). That would be link->irq.Handler = &mace_interrupt; link->irq.Instance = dev; in nmclan_attach(). Nothing ever modifies that beast afterwards and dev sure as hell can't be NULL in nmclan_attach() (explict check and a bunch of dereferencings prior to that point).
Adrian, could you please _read_ the code you are modifying? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |